-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement all missing entities and remove overrides on default impl data values. [1.14] #2468
Conversation
...ava/org/spongepowered/common/mixin/api/mcp/entity/projectile/EvokerFangsEntityMixin_API.java
Outdated
Show resolved
Hide resolved
.../org/spongepowered/common/mixin/api/mcp/entity/passive/horse/TraderLlamaEntityMixin_API.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/AreaEffectCloudEntityMixin_API.java
Outdated
Show resolved
Hide resolved
a19e559
to
0334629
Compare
fe5af94
to
dc6d8ee
Compare
...ain/java/org/spongepowered/common/mixin/api/mcp/entity/monster/PatrollerEntityMixin_API.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All legacy data manipulator methods should be deleted if they've been transcribed as value getters now. Don't add an outer if
statement when the value is already returning an Optional
and an ifPresent
wraps around adding to the values set. If the value is present (by the provider system), it'll be present, no need to check implementation detail for it. Also, licenses ;)
src/main/java/org/spongepowered/common/mixin/accessor/entity/passive/FoxEntityAccessor.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/MobEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...va/org/spongepowered/common/mixin/api/mcp/entity/boss/dragon/EnderDragonEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...ain/java/org/spongepowered/common/mixin/api/mcp/entity/item/EnderCrystalEntityMixin_API.java
Outdated
Show resolved
Hide resolved
.../spongepowered/common/mixin/api/mcp/entity/projectile/DamagingProjectileEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/FishingBobberEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...a/org/spongepowered/common/mixin/api/mcp/entity/projectile/ShulkerBulletEntityMixin_API.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/item/ArmorStandEntityMixin_API.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/item/ItemEntityMixin_API.java
Outdated
Show resolved
Hide resolved
dc6d8ee
to
f9f3dea
Compare
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/AreaEffectCloudEntityMixin_API.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java
Show resolved
Hide resolved
.../spongepowered/common/mixin/api/mcp/entity/item/minecart/SpawnerMinecartEntityMixin_API.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/item/BoatEntityMixin_API.java
Show resolved
Hide resolved
...main/java/org/spongepowered/common/mixin/api/mcp/entity/monster/GuardianEntityMixin_API.java
Outdated
Show resolved
Hide resolved
.../org/spongepowered/common/mixin/api/mcp/entity/passive/horse/ZombieHorseEntityMixin_API.java
Show resolved
Hide resolved
...n/java/org/spongepowered/common/mixin/api/mcp/entity/player/ServerPlayerEntityMixin_API.java
Outdated
Show resolved
Hide resolved
f9f3dea
to
be7e1e0
Compare
...main/java/org/spongepowered/common/mixin/api/mcp/entity/monster/EndermanEntityMixin_API.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/EntityMixin_API.java
Show resolved
Hide resolved
...in/java/org/spongepowered/common/mixin/api/mcp/entity/item/ExperienceOrbEntityMixin_API.java
Outdated
Show resolved
Hide resolved
.../spongepowered/common/mixin/api/mcp/entity/item/minecart/SpawnerMinecartEntityMixin_API.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/MobEntityMixin_API.java
Outdated
Show resolved
Hide resolved
...main/java/org/spongepowered/common/mixin/api/mcp/entity/monster/EndermanEntityMixin_API.java
Show resolved
Hide resolved
...ava/org/spongepowered/common/mixin/api/mcp/entity/projectile/EvokerFangsEntityMixin_API.java
Outdated
Show resolved
Hide resolved
ede81e2
to
7636003
Compare
src/main/java/org/spongepowered/common/mixin/api/mcp/entity/passive/CatEntityMixin_API.java
Outdated
Show resolved
Hide resolved
…ns of data values which override default methods. The real big one, add api$getVanillaValues to all entities and implement about 90% of the adding to Sets
7636003
to
59b2eba
Compare
No description provided.